Show registration errors #3588
Show registration errors #3588
Conversation
see in docker desktop). Register in web and app can be the same?
|
|
|
I notice that the proposed changes affect many parts of the code that do not seem to be related to each other. Could you further explain why these modifications are necessary and how they are related to each other? It would be helpful to have a detailed description of your changes and their purpose, so that we can assess their impact on the overall project. Thank you (: |
|
It will only show the first error for each field. Seems like i would be not able to match fields with errors, because the registration class or user interface is injected directly from the package. |
| {% for key, error in form.vars.errors if not break %} | ||
| {% if error.cause.propertyPath == 'username' %} | ||
| <div class="alert alert-danger"> | ||
| <ul class="list-unstyled"> | ||
| <li> | ||
| <span class="glyphicon glyphicon-exclamation-sign"></span> | ||
| {{ error.message }} | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| {% set break = true %} | ||
| {% endif %} | ||
| {% endfor %} |
There was a problem hiding this comment.
This shouldn't be needed, the form itself should render the error.
There was a problem hiding this comment.
It doesn't, There are 2 problems
- Error bubbling cannot be activated as the form doesn't inherit, it is injected but also directly referenced from the vendor code. The configuration for validations seems to be not present and without inheriting, i don't know how can i configure error bubbling.
- Validation also is not set up in a way that we can validate the password's security and choose which validations are active for the email and username (we want to prevent the "already used" message from showing)
alexsegura
changed the title
|
Registration errors are not mapped to individual fields in NucleosProfileBundle < 2 (nucleos/NucleosProfileBundle#154) |
|
Superseded by #3719 |
see in docker desktop). Register in web and app
can be the same?