Calculate the distance for a task into a tasklist even when no vehicle is set #4805
Conversation
Atala
force-pushed
the
calculate-distance-on-each-task
branch
from
3f71483 to
c39304f
Compare
Atala
requested review from
alexsegura
and removed request for
alexsegura and
vladimir-8
There was a problem hiding this comment.
Where do you plan to use distance and CO2 emissions?
I'm not sure that putting them into a Task entity is a good idea. It seems to me that distanceFromPrevious, at least, belongs more to a TaskCollectionItem, as it depends on the position of a Task in a list and should be managed together.
There was a problem hiding this comment.
I was wondering about that as well.
At the time I put it on Task directly, as we are for real interested only on the last value: a task may be assigned several days in a row, but actually only the last assignment if several make sense (when we accomplish the task for real). so in reality there is only one value we are interested into.
There was a problem hiding this comment.
(also coopcycle/coopcycle#166 )
There was a problem hiding this comment.
we are for real interested only on the last value
Then it seems a waste of time to recalculate all these values all the time. Maybe subscribe to a task:done event and calculate them only then? (I'd also rename the fields in that case to something in the past like traveled_distance, co2_consumed)
|
Issue here coopcycle/coopcycle#167 |
No description provided.