Added tasks to install correct wkhtmltopdf version and nedded packages #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't this Ansible work? You should just declare which version you need and Ansible will take care of that. If the problem is that in the Ubuntu repositories that specific version is still not available we should just add a PPA or tell Ansible to install the package compiling it or something like that. What do you think? |
danypr92
commented
Aug 28, 2018
tasks/main.yml
Outdated
| - git | ||
|
|
||
| - import_tasks: wkhtmltopdf.yml | ||
| tags: pdf |
danypr92
commented
Aug 28, 2018
tasks/wkhtmltopdf.yml
Outdated
| register: install_wkhtmltopdf | ||
| when: "widgetizer_target_version is not defined or 0.12.4 not in wkhtmltopdf_version.stdout" | ||
|
|
||
| - name: Download wkhtmltopdf version 0.12.4 |
There was a problem hiding this comment.
We can get the .deb package from: https://wkhtmltopdf.org/downloads.html using the checksum
danypr92
commented
Sep 3, 2018
tasks/wkhtmltopdf.yml
Outdated
| mode: 0777 | ||
| when: "install_wkhtmltopdf is defined or '0.12.4' not in result_b.stdout" | ||
|
|
||
| - name: Untar wkhtmltopdf package |
There was a problem hiding this comment.
We can use apt module to install from deb file.
enricostano
changed the title
With this update we allow install wkhtmltopdf in: * Ubuntu Trusty (14.04) * Ubuntu Xenial (16.04) * Ubuntu Bionic (18.04) https://wkhtmltopdf.org/downloads.html > This change is only tested with Ubuntu, it is not tested in other Linux distributions.
enricostano
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixing the problem raised when trying to print an invoice.
Propose
I found this gist with the solution to our problem.
The problem is the Wkhtmltopdf version. We need to install the version
0.12.4and we have installed0.12.2.I am working on tasks to cover this process and to sure that the correct version was installed.