Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gems with security alerts (rails, nokogiri, jquery) #197

Merged
merged 2 commits into from
Mar 24, 2016

Conversation

rewritten
Copy link
Contributor

No description provided.

@rewritten
Copy link
Contributor Author

Travis complains about something when initializing the Rollbar integration, but I'm not really sure it's safe to skip it.

group :development do
gem "binding_of_caller"
gem "better_errors"
gem "rubocop"
gem "haml-lint"
gem 'web-console', '~> 2.0'
gem 'web-console', '~> 2.1.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason this one uses ~> ? 😬

@enricostano
Copy link
Contributor

Travis complains about something when initializing the Rollbar integration, but I'm not really sure it's safe to skip it.

https://github.com/coopdevs/timeoverflow/blob/master/config/initializers/rollbar.rb

@rewritten
Copy link
Contributor Author

Of course but th exception is raised in

~/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rollbar-1.3.2/lib/rollbar/rake.rb:23:in `patch?'

@enricostano
Copy link
Contributor

rollbar (1.3.2)

try to update it

EDIT: current version 2.8.3

@rewritten
Copy link
Contributor Author

Found: rollbar/rollbar-gem#397

@rewritten
Copy link
Contributor Author

I wouldn't update without a clear reason (in this case it's in https://github.com/rollbar/rollbar-gem/blob/master/CHANGELOG.md#283)

@rewritten rewritten merged commit 44819d6 into master Mar 24, 2016
@rewritten rewritten deleted the feature/fix-security-alerts-from-gemnasium branch March 24, 2016 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants