Start Storybook and react components additions #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h reverted postcss version
…n storybook preview.js
…o react components and update jest.config
…r, followed dir pattern from foundation-forms
… imports into components
…CI error. Relates to storybook depencies for postcss beign out of date postcss8 and webpack5 causing build failures in storybook. Known issue with storybook that's being worked on
…components, switch className prop to quoteLarge variant with tests and css
|
@dalecreativ everything is looking great. I think as a first pass for getting React into here this is great. We have already spoken about the use of React Testing Library over Enzyme for integration level testing. I think some next steps would be:
|
…d packages. Update configs to remove enzyme testSetup
|
@mchadwickweb I've updated the dependencies for react-testing-library and removed deps on enzyme and react-test-renderer. Made sure to update the tests and snapshots for the components too. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook and react additions
What we've done:
babel.config.jsfor react buildscomponent-templatepackage to help start new react components.component-blockquote, includes a react component, styles and jest tests.To test:
Start the storybook app
confirm working with stories at
localhost:6006Run a build
Should build all packages without error.
NOTES:
Storybook react 6.1 > 6.2 has had known issues around its dependencies.
This has caused issues with builds for storybook when using packages like
postcss v8in your own projects that use storybook. As a temporary measure, we've downgraded the postcss version to 7, until an official patch has been released.Issues and discussions from storybook:
UPDATE: Storybook are currently on beta release of 6.2. With some updates and a additional addon
@storybook/addon-postcss. We're now able to build without error.I've set up a branch to help track beta to production release here : https://github.com/coopdigital/coop-frontend/tree/storybook-beta-with-postcss8