Skip to content

Commit

Permalink
fixup! [ADD] hr_timesheet_overtime_begin_end
Browse files Browse the repository at this point in the history
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
  • Loading branch information
carmenbianca committed Jul 11, 2024
1 parent 7b15e21 commit 6d5fbbd
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 20 deletions.
7 changes: 0 additions & 7 deletions hr_timesheet_overtime_rate/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ At time of writing (2024-06-28), the way a rate is computed for a date is by
looking _exclusively_ at the corresponding day of the week. This should be more
robust.

Because ``unit_amount`` is computed from ``hours_worked``, this module is not
compatible with ``hr_timesheet_begin_end``.To make this module subsequently
compatible with ``hr_timesheet_begin_end``, ``hours_worked`` must be computed
from ``time_stop`` and ``time_start``, and ``unit_amount`` must use this
module's computation method instead of ``hr_timesheet_begin_end``'s. The
compatibility layer should go into its own module.

Furthermore, the summary view of timesheet sheets are set read-only in this
module. Because of programming complexities, it is not easy to change this view
to use ``hours_worked`` instead of ``unit_amount``.
Expand Down
7 changes: 0 additions & 7 deletions hr_timesheet_overtime_rate/readme/ROADMAP.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,6 @@ At time of writing (2024-06-28), the way a rate is computed for a date is by
looking _exclusively_ at the corresponding day of the week. This should be more
robust.

Because ``unit_amount`` is computed from ``hours_worked``, this module is not
compatible with ``hr_timesheet_begin_end``.To make this module subsequently
compatible with ``hr_timesheet_begin_end``, ``hours_worked`` must be computed
from ``time_stop`` and ``time_start``, and ``unit_amount`` must use this
module's computation method instead of ``hr_timesheet_begin_end``'s. The
compatibility layer should go into its own module.

Furthermore, the summary view of timesheet sheets are set read-only in this
module. Because of programming complexities, it is not easy to change this view
to use ``hours_worked`` instead of ``unit_amount``.
6 changes: 0 additions & 6 deletions hr_timesheet_overtime_rate/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -391,12 +391,6 @@ <h1><a class="toc-backref" href="#toc-entry-1">Known issues / Roadmap</a></h1>
<p>At time of writing (2024-06-28), the way a rate is computed for a date is by
looking _exclusively_ at the corresponding day of the week. This should be more
robust.</p>
<p>Because <tt class="docutils literal">unit_amount</tt> is computed from <tt class="docutils literal">hours_worked</tt>, this module is not
compatible with <tt class="docutils literal">hr_timesheet_begin_end</tt>.To make this module subsequently
compatible with <tt class="docutils literal">hr_timesheet_begin_end</tt>, <tt class="docutils literal">hours_worked</tt> must be computed
from <tt class="docutils literal">time_stop</tt> and <tt class="docutils literal">time_start</tt>, and <tt class="docutils literal">unit_amount</tt> must use this
module’s computation method instead of <tt class="docutils literal">hr_timesheet_begin_end</tt>’s. The
compatibility layer should go into its own module.</p>
<p>Furthermore, the summary view of timesheet sheets are set read-only in this
module. Because of programming complexities, it is not easy to change this view
to use <tt class="docutils literal">hours_worked</tt> instead of <tt class="docutils literal">unit_amount</tt>.</p>
Expand Down

0 comments on commit 6d5fbbd

Please sign in to comment.