Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] hr_timesheet_overtime_rate_holidays #34

Open
wants to merge 6 commits into
base: 16.0
Choose a base branch
from

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Jun 21, 2024

Description

Don't apply overtime on timesheets made by holidays.

Based on top of #41

Odoo task (if applicable)

T12628

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • (If a new module) Moving this to OCA has been considered.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
This functionality was completely unlinked from the rest of
hr_timesheet_overtime.

I would have done this in two commits, but then the files wouldn't move
over cleanly, losing history.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca carmenbianca marked this pull request as draft July 18, 2024 09:53
@carmenbianca carmenbianca marked this pull request as ready for review July 18, 2024 12:08
@carmenbianca carmenbianca force-pushed the 16.0-add-holiday-compat branch 3 times, most recently from 2d85032 to da0229e Compare July 18, 2024 12:26
@carmenbianca carmenbianca changed the title [16.0][ADD] hr_timesheet_overtime_holidays [16.0][ADD] hr_timesheet_overtime_rate_holidays Jul 18, 2024
…pi.model method

This makes it easier to extend with additional available information on
the record.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(only reviewed the last commit, the rest will go in #41.)

slight (cosmetic) changes needed, otherwise lgtm.

hr_timesheet_overtime_rate_holidays/__manifest__.py Outdated Show resolved Hide resolved
hr_timesheet_overtime_rate_holidays/__manifest__.py Outdated Show resolved Hide resolved
hr_timesheet_overtime_rate_holidays/__manifest__.py Outdated Show resolved Hide resolved
hr_timesheet_overtime_rate_holidays/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
I really dislike writing Odoo tests. They take so so so so long to
write, building a global state like a house of cards.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants