Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider tasks for template unsafety if they're being skipped #1598

Closed
yajo opened this issue Apr 20, 2024 · 0 comments · Fixed by #1681
Closed

Don't consider tasks for template unsafety if they're being skipped #1598

yajo opened this issue Apr 20, 2024 · 0 comments · Fixed by #1681
Labels
Milestone

Comments

@yajo
Copy link
Member

yajo commented Apr 20, 2024

          Consider migrations. Even if the template uses migrations, we only mark it as unsafe if the current update will trigger them.

In the same fashion, if it has tasks but you're ignoring them, there's no unsafety produced by tasks. Other unsafety criteria should still be honored, but not that one.

Originally posted by @yajo in #1561 (comment)

Actually we could even add ˋ--skip-tasksˋ as an alternative to ˋ--trustˋ when suggesting the user what to do with that unsafety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant