-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parse templates in _answers_file setting #1027
feat: Parse templates in _answers_file setting #1027
Conversation
Great! Would be nice if this feature is added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of suggestions for improvement. But overall it looks good to me. 🙂
@yajo Would you mind taking a look and approving the workflow runs? |
@sisp Are you able to trigger the workflow runs for this PR? |
I don't think I can help because I have no permissions for this project. |
@yajo Sorry for the bump but wondering if you can approve these workflow runs? |
@yajo Any concerns with letting the workflows run? |
Triggered! No concerns, just I had 120 emails from copier 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty clean, thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
- Coverage 96.56% 96.36% -0.20%
==========================================
Files 41 43 +2
Lines 3054 3247 +193
==========================================
+ Hits 2949 3129 +180
- Misses 105 118 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Adds the ability for
_answers_file
to contain template variables. For example:Closes #866
Since #882 seems to have been abandoned and the tests weren't actually working, I've opened up this PR instead.