-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --trust
as a less scary alternative to --UNSAFE
#1179
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 96.73% 96.74%
=======================================
Files 47 47
Lines 3925 3937 +12
=======================================
+ Hits 3797 3809 +12
Misses 128 128
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions or ideas from my end, see inline comments.
--trusted
as a less scary alternative to --UNSAFE
--trust
as a less scary alternative to --UNSAFE
See rationale in #1137 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor request, looks great otherwise. 👌
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only remaining problem is the missing import of the Union
type now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
See rationale in #1137 (comment).