Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --trust as a less scary alternative to --UNSAFE #1179

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

yajo
Copy link
Member

@yajo yajo commented Jun 10, 2023

See rationale in #1137 (comment).

@yajo yajo added this to the Soon milestone Jun 10, 2023
@yajo yajo self-assigned this Jun 10, 2023
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #1179 (1b716d5) into master (dd0eb35) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   96.73%   96.74%           
=======================================
  Files          47       47           
  Lines        3925     3937   +12     
=======================================
+ Hits         3797     3809   +12     
  Misses        128      128           
Flag Coverage Δ
unittests 96.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
copier/cli.py 100.00% <ø> (ø)
tests/test_unsafe.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@yajo yajo mentioned this pull request Jun 10, 2023
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions or ideas from my end, see inline comments.

tests/test_unsafe.py Outdated Show resolved Hide resolved
copier/cli.py Outdated Show resolved Hide resolved
@yajo yajo changed the title feat: add --trusted as a less scary alternative to --UNSAFE feat: add --trust as a less scary alternative to --UNSAFE Jun 12, 2023
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor request, looks great otherwise. 👌

tests/test_unsafe.py Outdated Show resolved Hide resolved
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only remaining problem is the missing import of the Union type now.

@yajo yajo enabled auto-merge (squash) June 28, 2023 14:37
@yajo yajo disabled auto-merge June 28, 2023 14:38
@yajo yajo enabled auto-merge (squash) June 28, 2023 14:38
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@yajo yajo merged commit aaf6cf3 into master Jun 28, 2023
@yajo yajo deleted the trusted branch June 28, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants