gitignored file #1373
Merged
gitignored file #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1373 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 48 48
Lines 4423 4430 +7
=======================================
+ Hits 4310 4317 +7
Misses 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yajo
requested changes
Oct 22, 2023
|
Looks like you have to reformat the code. Run |
|
Thanks @yajo for your review |
auto-merge was automatically disabled
October 24, 2023 08:43
Head branch was pushed to by a user without write access
yajo
requested changes
Oct 24, 2023
|
I hope this one is the good one :) |
yajo
approved these changes
Oct 28, 2023
a file in the template but gitignored in the project should persist in the filesystem
auto-merge was automatically disabled
November 7, 2023 14:05
Head branch was pushed to by a user without write access
hparfr
force-pushed
the
fix-gitignore-behavior-1162
branch
from
98b8880 to
9806d75
Compare
|
There war an issue with flake-check, I rebased and squashed on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a file in the template but gitignored in the project should persist in the filesystem
fixes #1162