Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support preserve_symlinks=False for directories #1820

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

coretl
Copy link
Contributor

@coretl coretl commented Oct 16, 2024

Fixes #1819

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (c53b928) to head (b404eb7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1820   +/-   ##
=======================================
  Coverage   97.78%   97.79%           
=======================================
  Files          49       49           
  Lines        5108     5116    +8     
=======================================
+ Hits         4995     5003    +8     
  Misses        113      113           
Flag Coverage Δ
unittests 97.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @coretl! 👌 Thanks for identifying this bug and fixing it so promptly! 🙇 Apologies for the regression.

@sisp sisp merged commit 558f51c into copier-org:master Oct 16, 2024
22 checks passed
@coretl
Copy link
Contributor Author

coretl commented Oct 17, 2024

No problem, is there any chance of a patch release soon? Otherwise I'll have to communicate to users of our template that they need to downgrade copier to use it...

@sisp
Copy link
Member

sisp commented Oct 17, 2024

No problem, is there any chance of a patch release soon?

/cc @yajo

@yajo
Copy link
Member

yajo commented Oct 18, 2024

https://github.com/copier-org/copier/releases/tag/v9.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserve_symlinks=False not working for directory symlinks in 9.4
3 participants