Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt templating #190

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Add prompt templating #190

merged 1 commit into from
Apr 30, 2020

Conversation

pawamoy
Copy link
Contributor

@pawamoy pawamoy commented Apr 23, 2020

fix #90

TODO:

  • docstrings
  • tests
  • documentation

@pawamoy
Copy link
Contributor Author

pawamoy commented Apr 23, 2020

Hmmm... CONTRIBUTING does not mention Poetry at all, nor mypy. It mentions tox, but tox is not a dependency listed in pyproject.toml. I guess it should be updated 😅

@yajo
Copy link
Member

yajo commented Apr 24, 2020

You guess right. The docs are not good right now. 🤷‍♂️ To be done in #173

@yajo yajo marked this pull request as draft April 24, 2020 08:08
@yajo
Copy link
Member

yajo commented Apr 24, 2020

I took the freedom to convert this PR to draft, given you still have some TODO points pending.

Please ping me when it's ready to review, thanks!

@pawamoy pawamoy marked this pull request as ready for review April 24, 2020 17:25
@pawamoy
Copy link
Contributor Author

pawamoy commented Apr 24, 2020

@yajo ready 🙂

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

Also, could you please add a test where someone customizes env ops in their copier.yml and those are respected?

copier/config/factory.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
tests/test_templated_prompt.py Outdated Show resolved Hide resolved
@pawamoy
Copy link
Contributor Author

pawamoy commented Apr 27, 2020

Also, could you please add a test where someone customizes env ops in their copier.yml and those are respected?

Done!

copier/config/user_data.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/types.py Outdated Show resolved Hide resolved
copier/types.py Outdated Show resolved Hide resolved
copier/config/user_data.py Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/tools.py Outdated Show resolved Hide resolved
copier/tools.py Outdated Show resolved Hide resolved
copier/tools.py Outdated Show resolved Hide resolved
copier/tools.py Outdated Show resolved Hide resolved
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting very good shape.

copier/config/user_data.py Outdated Show resolved Hide resolved
copier/config/user_data.py Outdated Show resolved Hide resolved
copier/tools.py Outdated Show resolved Hide resolved
copier/tools.py Outdated Show resolved Hide resolved
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@yajo yajo merged commit 11bc27d into copier-org:master Apr 30, 2020
@yajo yajo added this to the v3.1.0 milestone Apr 30, 2020
@pawamoy pawamoy deleted the add-prompt-templating branch April 2, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt self-templating
2 participants