-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prompt templating #190
Conversation
Hmmm... CONTRIBUTING does not mention Poetry at all, nor mypy. It mentions tox, but tox is not a dependency listed in pyproject.toml. I guess it should be updated 😅 |
You guess right. The docs are not good right now. 🤷♂️ To be done in #173 |
I took the freedom to convert this PR to draft, given you still have some TODO points pending. Please ping me when it's ready to review, thanks! |
@yajo ready 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
Also, could you please add a test where someone customizes env ops in their copier.yml and those are respected?
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting very good shape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
fix #90
TODO: