Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the update process #267

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Document the update process #267

merged 1 commit into from
Sep 27, 2020

Conversation

pawamoy
Copy link
Contributor

@pawamoy pawamoy commented Sep 5, 2020

Resolves #239.

I think I managed to get a nice mermaid graph:

Screenshot_2020-09-05_12-59-48

One problem though: prettier does not understand markdown admonitions and dedents/breaks them.
Not sure if we should just drop the admonition, or find a way to make prettier happy.

EDIT: ref: prettier/prettier#9154

@pawamoy
Copy link
Contributor Author

pawamoy commented Sep 5, 2020

Hmm there was an update of the mermaid plugin and now it doesn't work as expected. Investigating.

EDIT: found the source: fralau/mkdocs-mermaid2-plugin#17

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase please.

Also, a rebase should trigger actions, which seem to be forever waiting now.

docs/updating.md Outdated Show resolved Hide resolved
@pawamoy
Copy link
Contributor Author

pawamoy commented Sep 5, 2020

It seems ReadTheDocs is breaking mkdocs.yml by adding contents to it. See how format becomes null instead of !!python/name:mermaid2.fence_mermaid:

 - pymdownx.superfences:
    custom_fences:
    - class: mermaid
      format: null

https://readthedocs.org/api/v2/build/11817460.txt

Properly reported here: readthedocs/readthedocs.org#6889 (comment)

And re-opened here: readthedocs/readthedocs.org#7461

@yajo
Copy link
Member

yajo commented Sep 7, 2020

Also, a rebase should trigger actions, which seem to be forever waiting now.

It's nice that now I see the builds got triggered, finally!

And re-opened here: readthedocs/readthedocs.org#7461

Yikes, so then we cannot merge this until that is fixed, right? Or we'd end up breaking our docs...

@pawamoy
Copy link
Contributor Author

pawamoy commented Sep 7, 2020

Yikes, so then we cannot merge this until that is fixed, right? Or we'd end up breaking our docs...

Indeed 😢

I don't mind letting this PR sit here until we get some news on that RTD issue 🙂

@yajo yajo marked this pull request as draft September 7, 2020 12:05
@yajo
Copy link
Member

yajo commented Sep 7, 2020

OK I set it to draft until then, to avoid further reviews.

@pawamoy
Copy link
Contributor Author

pawamoy commented Sep 25, 2020

Waiting for readthedocs/readthedocs.org#7507. In the meantime if we really want this now, there's a workaround: we can use <div class="mermaid">...</div> instead of a code-block with fences.

@yajo
Copy link
Member

yajo commented Sep 25, 2020

Great idea!

@pawamoy pawamoy force-pushed the docs-graph branch 3 times, most recently from e858b02 to a5d4524 Compare September 26, 2020 13:35
@pawamoy
Copy link
Contributor Author

pawamoy commented Sep 26, 2020

Damn, prettier refuses to ignore the div when I wrap it inside <!-- prettier-ignore-start --> comments...

@yajo yajo marked this pull request as ready for review September 27, 2020 09:02
@yajo
Copy link
Member

yajo commented Sep 27, 2020

This looks pretty good, but you need to fix the docs build and run pre-commit for it to be merged.

Thanks again!

Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>
@pawamoy
Copy link
Contributor Author

pawamoy commented Sep 27, 2020

Apparently prettier expects a blank line before the <!-- prettier-ignore-end --> comment for it to work (see this comment)

@yajo yajo merged commit 9e3f151 into copier-org:master Sep 27, 2020
@yajo
Copy link
Member

yajo commented Jan 20, 2021

So how shall we proceed now that readthedocs/readthedocs.org#7507 is fixed?

@pawamoy
Copy link
Contributor Author

pawamoy commented Jan 20, 2021

We can now configure superfences for mermaid blocks: https://github.com/fralau/mkdocs-mermaid2-plugin#declaring-the-superfences-extension. If you have access to the Insiders of mkdocs-material (through sponsoring), you can follow this: https://squidfunk.github.io/mkdocs-material/reference/diagrams/#superfences and even remove the dependency to the mermaid plugin

And in the Markdown page, use a proper triple-backticks code block instead of a div with mermaid class. The prettier comments can also be removed I think.

However I don't know when RTD will release this just-merged PR!

@pawamoy pawamoy deleted the docs-graph branch April 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: draw the logic graph
2 participants