Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn major version difference #359

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Warn major version difference #359

merged 1 commit into from
Feb 14, 2021

Conversation

yajo
Copy link
Member

@yajo yajo commented Feb 14, 2021

Targeting #348, from now on, if we cannot check the copier version or the installed version's major part is bigger than the template's minimal major part, there'll be proper warnings.

Targeting #348, from now on, if we cannot check the copier version or the installed version's major part is bigger than the template's minimal major part, there'll be proper warnings.
@codecov-io
Copy link

codecov-io commented Feb 14, 2021

Codecov Report

Merging #359 (10e87b7) into master (b3190c2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   97.23%   97.21%   -0.03%     
==========================================
  Files          35       35              
  Lines        2097     2115      +18     
==========================================
+ Hits         2039     2056      +17     
- Misses         58       59       +1     
Flag Coverage Δ
unittests 97.21% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
copier/errors.py 100.00% <100.00%> (ø)
copier/template.py 98.50% <100.00%> (-0.73%) ⬇️
tests/test_minimum_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3190c2...10e87b7. Read the comment docs.

@yajo yajo self-assigned this Feb 14, 2021
@yajo yajo added this to the v6.0.0 milestone Feb 14, 2021
@yajo yajo merged commit 448812f into master Feb 14, 2021
@yajo yajo deleted the mincopierversionwarn branch February 14, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants