build(deps): remove upper bound from Python version specifier #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 41 41
Lines 2930 2930
=======================================
Hits 2831 2831
Misses 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
We originally left the Python 4 upper bound for reasons mentioned in #509. Great to learn it's not needed anymore |
sisp
deleted the
build/remove-upper-bound-from-python-version-specifier
branch
yajo
added a commit
that referenced
this pull request
Aug 28, 2022
pre-commit started failing with: ``` [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment more info: virtualenv python version did not match created version: - actual version: 3.10.6.final.0 - expected version: 3.10.4.final.0 ``` Quick fix while #696 gets on track. Sadly I had to rollback #752 due to PyCQA/isort#1945.
yajo
added a commit
that referenced
this pull request
Aug 28, 2022
pre-commit started failing with: ``` [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment more info: virtualenv python version did not match created version: - actual version: 3.10.6.final.0 - expected version: 3.10.4.final.0 ``` Quick fix while #696 gets on track. Sadly I had to rollback #752 due to PyCQA/isort#1945.
yajo
added a commit
that referenced
this pull request
Aug 28, 2022
pre-commit started failing with: ``` [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... An unexpected error has occurred: AssertionError: BUG: expected environment for python to be healthy immediately after install, please open an issue describing your environment more info: virtualenv python version did not match created version: - actual version: 3.10.6.final.0 - expected version: 3.10.4.final.0 ``` Quick fix while #696 gets on track. Sadly I had to rollback #752 due to PyCQA/isort#1945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capping the Python version (e.g.
<4) is a bad practice, so I've removed it.