Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub prompt template intended to guide a structured assessment of unit/E2E test coverage for the Java SDK (events, hooks, and core session behaviors).
Changes:
- Introduces a new prompt document for enumerating testable components (events/hooks) and mapping them to existing tests.
- Defines a standardized report format (tables, summary, gaps, and recommendations) and includes verification commands.
Comments suppressed due to low confidence (2)
.github/prompts/test-coverage-assessment.prompt.md:73
- The Hook Types Coverage table example also uses
||at the start of each row, which adds an unintended empty column and can prevent proper Markdown table rendering. Switch to single|row delimiters.
| Hook Type | Handler Interface | Unit Test | E2E Test | Notes |
|-----------|-------------------|:---------:|:--------:|-------|
| `preToolUse` | `PreToolUseHandler` | ✅/❌ | ✅/❌ | Any notes |
| ... | ... | ... | ... | ... |
.github/prompts/test-coverage-assessment.prompt.md:80
- The Coverage Summary table example uses
||row prefixes, which typically renders as an extra empty first column and misaligned separators. Use standard Markdown table syntax with single leading|per row.
| Category | Total | Unit Tested | E2E Tested | Coverage % |
|----------|-------|-------------|------------|------------|
| Events | X | X | X | X% |
| Hooks | X | X | X | X% |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+63
to
+66
| | Event Type | Event Class | Unit Test | E2E Test | Notes | | ||
| |------------|-------------|:---------:|:--------:|-------| | ||
| | `session.start` | `SessionStartEvent` | ✅/❌ | ✅/❌ | Any notes | | ||
| | ... | ... | ... | ... | ... | |
There was a problem hiding this comment.
These Markdown table examples start each row with ||, which creates an extra empty first column and breaks the header separator alignment in most renderers. Use a single leading | for each row so the tables render correctly.
This issue also appears in the following locations of the same file:
- line 70
- line 77
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new prompt template for test coverage assessment in
.github/prompts/test-coverage-assessment.prompt.md.