feat: use latest @copilot-extensions/preview-sdk and all its goodies
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
commented
Sep 5, 2024
gr2m
commented
Sep 5, 2024
gr2m
force-pushed
the
moar-sdk
branch
5 times, most recently
from
7b28812
to
bcd67e9
Compare
JasonEtco
reviewed
Sep 9, 2024
| @@ -162,9 +166,9 @@ const server = createServer(async (request, response) => { | |||
| const chunkStr = "data: " + JSON.stringify(chunk) + "\n\n"; | |||
| response.write(chunkStr); | |||
| } | |||
| response.write("data: [DONE]\n\n"); | |||
|
|
|||
| response.end(createDoneEvent()); | |||
src/index.ts
Outdated
| @@ -89,56 +89,60 @@ const server = createServer(async (request, response) => { | |||
|
|
|||
| console.time("tool-call"); | |||
| const toolCaller = await capiClient.chat.completions.create({ | |||
| // @ts-expect-error - type error due to Copilot/OpenAI SDKs interop, I'll look into it ~@gr2m | |||
There was a problem hiding this comment.
I'd opt to wait until we've resolved this to ship
There was a problem hiding this comment.
it has been removed via #8
…Copilot Extension SDKs
gr2m
commented
Sep 10, 2024
Comment on lines
+102
to
+103
| // @ts-expect-error - type error due to Copilot/OpenAI SDKs interop, I'll look into it ~@gr2m | ||
| toolCaller.choices[0] |
There was a problem hiding this comment.
this is not a straight forward fix, not like #6 (comment). I will look into it, your call if you want to merge it or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the app has no other dependencies except
@copilot-extensions/preview-sdkLet me know what you think about the changes.