Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): open-cli #102

Merged
merged 2 commits into from
Sep 18, 2024
Merged

build(deps): open-cli #102

merged 2 commits into from
Sep 18, 2024

Conversation

gr2m
Copy link
Collaborator

@gr2m gr2m commented Sep 18, 2024

we missed that one :)

@francisfuzz
Copy link
Collaborator

@gr2m - Neat, TIL about this package! I'm wondering in what ways we currently (and intend to) use it? 💭

@gr2m
Copy link
Collaborator Author

gr2m commented Sep 18, 2024

I'm wondering in what ways we currently (and intend to) use it? 💭

it's used in the coverage script. We use it to open the HTML coverage report after the report is created:

preview-sdk.js/package.json

Line 36 in 1f56d8e

"postcoverage": "open-cli coverage/index.html"

Try this

npm test
npm run coverage

@gr2m gr2m merged commit 76306f0 into main Sep 18, 2024
5 checks passed
@gr2m gr2m deleted the add-missing-open-cli-dev-dependency branch September 18, 2024 20:43
@oscard0m oscard0m mentioned this pull request Sep 18, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gr2m @francisfuzz