-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out 192 Singular Plural Issue | Alignment Issue #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… has no rows inside it (#51) * show widget on initial load * Out 188 Every time I load the app, I’m taken part of the way down the page (#52) * fix unwanted scroll * Out 197 Miscellaneous (#53) * completely disable app bridge for IU * take back notification modal to default state * added /s in each notification * show error if IU unselects all 3 apps * adds tasks conditionally
aatbip
added a commit
that referenced
this pull request
Mar 21, 2024
* total tasks only count apps that are visible * total tasks only count apps that are visible * Out 192 Singular Plural Issue | Alignment Issue (#50) * fixes singular plural issue + fixes alignment * Out 189 When I toggle Display Tasks on for the first time, the widget has no rows inside it (#51) * show widget on initial load * Out 188 Every time I load the app, I’m taken part of the way down the page (#52) * fix unwanted scroll * Out 197 Miscellaneous (#53) * completely disable app bridge for IU * take back notification modal to default state * added /s in each notification * show error if IU unselects all 3 apps * adds tasks conditionally * changed logic to use some function
aatbip
added a commit
that referenced
this pull request
Mar 22, 2024
* chore(ui): add switch icons * chore(ui): add components for switch icons * feat(ui): add context state for displayTasks * feat(ui): show display tasks switch in sidebar * feat(ui): add Switch component for copilot * feat(ui): add Display Tasks component for copilot * feat(db): add displayTasks to settings table * chore(ui): add global-error so Sentry stops complaining * feat(ui): state management for displayTasks * feat(api): save and fetch displayTasks data * fix: parse token and client id using zod * feat(ui): add customize button * chore: read sentry environment from env vars * added custom extension for notification widget * exploring ways and best solutions * chore: add necessary icons and icon type * feat: add utils for dealing with strings * feat: add notifications modal * refactor: move display tasks component * chore: add notification option types * feat: inject notification state to global context * fix: rename toggle file * fix: use workspace font * fix: minor design issues * feat: hook notifications modal to state * feat: add notifications to schema * refactor: clean code * feat: add types for notifications * fix: everything * feat: add util to order orderable arrays * feat: integrate notifications with API * fix: sideeffect issue on toggle with newly created client * chore: type gymnastics * refactor: make default notification options a util * refactor: move to another components folder * feat: implement dnd * feat: implement drag handles * feat: slight animation * trying out various approaches * fix: attach sensors to dnd context * feat: mock API for client notification count * chore: bump copilot-node-sdk to 1.3.0 * feat: implement notifications count API * fix: use http 500 as fallback status code * refactor: move notification events to util * just exploring solutions * fix: issues with autofill fields * fix: issues with autofill fields * removed unwanted file * fix minor bug * removed unwanted code * chore: add http-status package * refactor: move derived error to exceptions namespace * fix: minor PR fixes * docs: document changes * refactor: PascalCase error class * hotfix: make notifications usable in IU preview * Out 92 Show notification counts in preview and client modes (#44) * render counts in preview and client modes * added route + fix bugs * display task slider toggles when widget is removed * don't navigate IU in preview mode * handle displaying notifications based on counts * handle default state in client preview * fixed major bugs and PR reviews * fixed major bugs and PR reviews * update route for billing app * ok that didn't work * Out 193 Total tasks should only count apps that are visible (#49) * total tasks only count apps that are visible * total tasks only count apps that are visible * Out 192 Singular Plural Issue | Alignment Issue (#50) * fixes singular plural issue + fixes alignment * Out 189 When I toggle Display Tasks on for the first time, the widget has no rows inside it (#51) * show widget on initial load * Out 188 Every time I load the app, I’m taken part of the way down the page (#52) * fix unwanted scroll * Out 197 Miscellaneous (#53) * completely disable app bridge for IU * take back notification modal to default state * added /s in each notification * show error if IU unselects all 3 apps * adds tasks conditionally * changed logic to use some function * update plural logic for cleaner copy (#54) * Out 202 207 Banner image issue and autofill issue (#55) * fix autofill issue, banner image issue * removed log * Out 207 (#56) * fix autofill issue, banner image issue * removed log * another fix for autofill issue * fixing autofill issue * removed start to try fixing autofill issue in prod * resolving autofill issue * resolving autofill issue * resolving autofill issue * resolving autofill issue * resolving autofill issue * resolving autofill issue * fixes issue with autofill field * handle prettier error * minor fixes * fix bugs --------- Co-authored-by: aatbip <anantabipal2010@gmail.com> Co-authored-by: Potluck Mittal <potluck@copilot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://linear.app/copilotplatforms/issue/OUT-192/singularplural-issues
Ref: https://linear.app/copilotplatforms/issue/OUT-191/weird-vertical-alignment-in-the-widget