OUT-106 Add Embed Type #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rrojan
requested changes
Mar 25, 2024
| return { | ||
| setIframe: | ||
| (options: { src: string }) => | ||
| ({ tr, dispatch }) => { |
There was a problem hiding this comment.
I see formating error here @aatbip
|
@aatbip please address lint and type warnings. |
@saugatmaharjan This PR will get merged to #58 which has the linters setup. |
saugatmaharjan
approved these changes
Mar 26, 2024
aatbip
added a commit
that referenced
this pull request
Mar 26, 2024
* fix: editor scrolls between mode changes * fix: editor scrolls between mode changes * default state client.givenName change to pill * background picker z index fix * added swr * fix z index of select * fix editable false in client preview * setup prettier with eslint again * turned off indent rule * setup prettier again + removed semi * changes in eslint and prettier config * fix indentation * fix indentation * refac eslintrc config * removed identation from eslintrc * removed unused vars * OUT-106 Add Embed Type (#59) * added embed functionality * added Iframe extension to client preview * added cursor auto to readonly mode in widget * use promise.all in client preview server component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://linear.app/copilotplatforms/issue/OUT-106/add-embed-type-to-client-home