fix(OUT-1284): marketplace app support object for customField value #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MysteryMachine
approved these changes
Jan 15, 2025
|
I think we have a stricter schema in our codebase if there's any interest in copying over, keeping it synced will be a pain but hopefully we dont have schema changes super regularly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Ticket
[IU is receiving an error for Client Home app](Task Link)
Root Cause
We updated how custom fields value can be returned. Previously it was either a string or array and now it can also be an object. This was causing a zodSchema defined in client home to fail and caused the page to crash.
The main changes are
Update the union in the zod schema to allow objects along side string and array.
I didn't spent too much time debugging this. Im going to open a sub-ticket for Outside to make this more robust. The whole app should not crash in cases like this.