Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(POR-12904): client home not loading for clients without custom fields #78

Conversation

makeitraina
Copy link
Member

@makeitraina makeitraina commented Jan 16, 2025

Task/Ticket

[No client with token client home error](Task Link)

The main changes are

Check for customFields existing before iterating over them.

Root Cause

  • this was a regression caused by a recent fix to show fullAddress in client home.
  • we only tested when custom fields was present and not when it was not set.

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
client-home ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 4:24pm

Copy link

linear bot commented Jan 16, 2025

Copy link

sentry-io bot commented Jan 16, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/app/client-preview/page.tsx

Function Unhandled Issue
ClientPreviewPage TypeError: Cannot convert undefined or null to object ClientPreviewPage(server/app/client-preview/custom-app-base/src/app/client-preview/...
Event Count: 82 Affected Users: 0

Did you find this useful? React with a 👍 or 👎

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@makeitraina makeitraina merged commit 6dc57e1 into main Jan 16, 2025
4 checks passed
@makeitraina makeitraina deleted the neil/fix-por-12904-client-home-not-loading-for-clients-without-custom-fields branch January 16, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants