Skip to content
This repository was archived by the owner on Oct 24, 2022. It is now read-only.
This repository was archived by the owner on Oct 24, 2022. It is now read-only.

Don't use SSLv3 #39

Closed
Closed
@jdennes

Description

@jdennes

We have recently disabled support for SSLv3 at GitHub, as it is a very old version of the SSL protocol that is now also known to be vulnerable:

http://googleonlinesecurity.blogspot.com/2014/10/this-poodle-bites-exploiting-ssl-30.html
https://www.imperialviolet.org/2014/10/14/poodle.html

We have had several reports from GitHub users using the Pygithub3 library, complaining of failing requests due to the use of SSLv3 in the library. Here's an example traceback that has been reported:

Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/services/users/__init__.py", line 36, in get
return self._get(request)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/services/base.py", line 142, in _get
response = self._client.get(request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/core/client.py", line 83, in get
response = self.request('get', request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/core/client.py", line 70, in wrapper
return func(self, verb, request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/core/client.py", line 76, in request
response = self.requester.request(verb, request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/requests/sessions.py", line 252, in request
r.send(prefetch=prefetch)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/requests/models.py", line 632, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of protocol

/cc @copitux

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions