Skip to content
This repository was archived by the owner on Oct 24, 2022. It is now read-only.

Easify list by (default) conditions #38

Merged
merged 1 commit into from
Oct 23, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions pygithub3/services/issues/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ def __init__(self, **config):
self.milestones = Milestones(**config)
super(Issue, self).__init__(**config)

def list(self, filter='assigned', state='open', labels='', sort='created',
direction='desc', since=None):
def list(self, **params):
""" List your issues

:param str filter: 'assigned', 'created', 'mentioned' or 'subscribed'
Expand All @@ -33,14 +32,10 @@ def list(self, filter='assigned', state='open', labels='', sort='created',
.. warning::
You must be authenticated
"""
params = dict(filter=filter, state=state, labels=labels, sort=sort,
direction=direction)
request = self.request_builder('issues.list')
return self._get_result(request, **params)

def list_by_repo(self, user=None, repo=None, milestone='*', state='open',
assignee='*', mentioned='', labels='', sort='created',
direction='desc', since=None):
def list_by_repo(self, user=None, repo=None, **params):
""" List issues for a repo

:param str milestone: Milestone ID, 'none' or '*'
Expand All @@ -57,8 +52,6 @@ def list_by_repo(self, user=None, repo=None, milestone='*', state='open',
.. note::
Remember :ref:`config precedence`
"""
params = dict(milestone=milestone, state=state, assignee=assignee,
mentioned=mentioned, labels=labels, sort=sort, direction=direction)
request = self.make_request('issues.list_by_repo', user=user,
repo=repo)
return self._get_result(request, **params)
Expand Down
6 changes: 2 additions & 4 deletions pygithub3/services/issues/milestones.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ class Milestones(Service):
""" Consume `Milestones API
<http://developer.github.com/v3/issues/milestones>`_ """

def list(self, user=None, repo=None, state='open', sort='due_date',
direction='desc'):
def list(self, user=None, repo=None, **params):
""" List milestones for a repo

:param str user: Username
Expand All @@ -24,8 +23,7 @@ def list(self, user=None, repo=None, state='open', sort='due_date',
"""
request = self.make_request('issues.milestones.list', user=user,
repo=repo)
return self._get_result(request, state=state, sort=sort,
direction=direction)
return self._get_result(request, **params)

def get(self, number, user=None, repo=None):
""" Get a single milestone
Expand Down