Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch-networking: fix parsing of HTTP headers #1182

Merged
merged 7 commits into from
Nov 17, 2024
Merged

fetch-networking: fix parsing of HTTP headers #1182

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a8feef0
fetch-networking: fix parsing of HTTP headers with different number o…
SuperMaxusa Nov 10, 2024
c16f26e
use Header.append() instead Header.set(), added header validation
SuperMaxusa Nov 11, 2024
53acfad
added tests for incorrect headers
SuperMaxusa Nov 11, 2024
160d577
replacing by parse_http_header() method
SuperMaxusa Nov 11, 2024
d3998fc
added warn on failed check, removed a redundant check
SuperMaxusa Nov 12, 2024
245395e
simplied if condition
SuperMaxusa Nov 12, 2024
3f16601
small fix for warn
SuperMaxusa Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/browser/fetch_network.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ async function on_data_http(data)

let req_headers = new Headers();
for(let i = 1; i < headers.length; ++i) {
let parts = headers[i].split(": ");
let parts = headers[i].split(/:(.+)/);
SuperMaxusa marked this conversation as resolved.
Show resolved Hide resolved
let key = parts[0].toLowerCase();
let value = parts[1];
let value = parts[1].trim();
copy marked this conversation as resolved.
Show resolved Hide resolved
if( key === "host" ) target.host = value;
else if( key.length > 1 ) req_headers.set(parts[0], value);
SuperMaxusa marked this conversation as resolved.
Show resolved Hide resolved
}
Expand Down
Loading