Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to MC#1256 #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adapt to MC#1256 #26

wants to merge 1 commit into from

Conversation

Tragicus
Copy link

@Tragicus Tragicus commented Aug 21, 2024

math-comp/math-comp#1256 changes the behavior of rewrite (seemingly because it generalizes some operations). This PR makes the necessary changes to keep compiling.

The CI is supposed to fail because we need math-comp/algebra-tactics#100 first.

@Tragicus
Copy link
Author

Actually, if there is a way to reduce GRing_Nmodule__to__GRing_AddMagma ssrint_int__canonical__GRing_Nmodule to ssrint_int__canonical__GRing_AddMagma without mentioning addMagmaType and with a code that works on the current version of MC (i.e. when there is nothing to unfold), we may make the CI happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant