Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MathComp version to >= 1.12.0 #3

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Bump MathComp version to >= 1.12.0 #3

merged 2 commits into from
Dec 16, 2021

Conversation

pi8027
Copy link
Collaborator

@pi8027 pi8027 commented May 12, 2021

This PR makes apery compatible with MathComp 1.12.0 and later. It also cleans up proof scripts as preliminary work for #4. This PR itself does not add any extra dependency or enhance the proof automation facility.

Closes #2

@pi8027
Copy link
Collaborator Author

pi8027 commented May 12, 2021

coq-community/coqeal#38 and coq/opam#1714 should fix the CI failure with coq.dev.

@pi8027
Copy link
Collaborator Author

pi8027 commented Oct 4, 2021

@pi8027
Copy link
Collaborator Author

pi8027 commented Oct 11, 2021

It seems that math-comp/math-comp#766 made hanson.v diverging🤦‍♂️

@pi8027 pi8027 changed the title Bump the minimum MathComp version to 1.12.0 Bump MathComp version to 1.12.0 Oct 12, 2021
@pi8027 pi8027 changed the title Bump MathComp version to 1.12.0 Bump MathComp version to >= 1.12.0 Oct 24, 2021
@CohenCyril
Copy link

@pi8027 FYI, I started the CI again to test the to be released version of mathcomp

@pi8027
Copy link
Collaborator Author

pi8027 commented Oct 26, 2021

I think this PR is ready. Shall we merge so that we can test apery in MathComp CI? @amahboubi

@CohenCyril
Copy link

The CI failure is spurious (and should eventually be solved by math-comp/multinomials#53 and a release AFAIU).
@amahboubi do you have time to review this? Do you want someone else to review it?

@pi8027
Copy link
Collaborator Author

pi8027 commented Dec 15, 2021

CI green.

@amahboubi
Copy link
Collaborator

amahboubi commented Dec 15, 2021

Many thanks @pi8027 for this amazing work. I do not have time for reviewing such a PR right away, but I am of course fine with a review by someone else, or even with a merge after minimal checks.

Copy link

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amahboubi

Many thanks @pi8027 for this amazing work. I do not have time for reviewing such a PR right away, but I am of course fine with a review by someone else, or even with a merge after minimal checks.

I did a minimal check, and I approve.

@amahboubi
Copy link
Collaborator

Thanks a lot!

@amahboubi amahboubi merged commit 5b40420 into coq-community:master Dec 16, 2021
@pi8027
Copy link
Collaborator Author

pi8027 commented Dec 16, 2021

Thanks!

@pi8027 pi8027 deleted the mathcomp-1.12.0 branch December 16, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Coq/Mathcomp versions
3 participants