Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with new chown command #85

Closed
wants to merge 2 commits into from

Conversation

yforster
Copy link
Member

As discussed on Zulip, at least for MetaCoq we need to fix permissions already before the installation, otherwise installing dependencies via opam fails.

@yforster
Copy link
Member Author

The sentence This is not an issue when relying on opam to build the Coq project. in the README might be incorrect with the newest git version. To me, it might be reasonable to run the chown by default in before_install.

@erikmd
Copy link
Member

erikmd commented Mar 23, 2023

Thanks @yforster!

Actually I won't be able to merge your patch because:

  • before_install already has a value that should be kept;
  • merely tweaking before_install won't be enough because the following step would be missing:
  - name: Revert permissions
    # to avoid a warning at cleanup time
    if: ${{ always() }}
    run: sudo chown -R 1001:116 .  # <--

So I believe I'll come up with a (pre-entrypoint, post-entrypoint)-based solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants