Cancel parsing event #941
Draft
Cancel parsing event #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to interupt a full document parse, we first need to make it part of the event loop.
We introduce parse events for each line which will allow for better interuptibility as well as laying the ground work for blocking on parse errors.
This brings back performance to acceptable levels.
- Removed some commented out dead code - Cleaned up ParseEvent (it doesnt need any info) - Cleaned up the api (removed unecessary variables to init, reset, etc...) - Removed cancel handle for ParseEvent
Now instead of launching execution directly from the lsp event, we queue a new event that has less priority then parsing.
WIP: something fishy is still happening with the overview
The operations on range lists used to compute the overview could be re-used somewhere else
rtetley
force-pushed
the
cancel-event
branch
from
4d7bc58
to
0f03284
Compare
This will allow to easily recompute the overview from an invalidated state, and makes a correspondance between an execution state and its overview.
This avoids two consecutive execution events happening at the same time and messing up the state. Additionally we move the parsing cancel handle to the document where it belongs.
|
This is a big one, still WIP. Needs:
|
We will now put the proof view handling in the document manager. Since ther return type for the handle event function is becoming quite big, we turn it into a record.
Even in continuous mode, observe_id will now indicate where the user clicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying another route from #937.
This time we use the SEL api to cancel events.
Currently does not seem to be working because of problem noted in gares/sel#10