Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MelGAN based vocoders do not use feature matching loss even if it is enabled. #419

Closed
erogol opened this issue Apr 7, 2021 · 1 comment · Fixed by #420
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@erogol
Copy link
Member

erogol commented Apr 7, 2021

Describe the bug
The condition checking for enabling feature_matching loss in

if self.use_feat_match_loss and not feats_fake:
is always False.

Probably all our trained models are affected by this bug and caused suboptimal results.

Specifically, I observed that it caused the metallic noise in the model outputs.

Expected behavior
The models should use feat_matching loss

Additional context
For anyone who needs an instant fix, the line indicated above needs to be updated as follows.

        if self.use_feat_match_loss and not feats_fake is None:
@erogol erogol added bug Something isn't working good first issue Good for newcomers labels Apr 7, 2021
@erogol
Copy link
Member Author

erogol commented Apr 7, 2021

fixed on dev

@erogol erogol closed this as completed Apr 7, 2021
@erogol erogol mentioned this issue Apr 7, 2021
11 tasks
erogol added a commit that referenced this issue Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant