Fix colliding dataset cache file names #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erogol
requested changes
Sep 20, 2022
TTS/tts/datasets/dataset.py
Outdated
| @@ -34,6 +35,13 @@ def noise_augment_audio(wav): | |||
| return wav + (1.0 / 32768.0) * np.random.rand(*wav.shape) | |||
|
|
|||
|
|
|||
| def string2filename(string): | |||
| # return re.sub('[^\w_.)( -]', '_', string) | |||
There was a problem hiding this comment.
We need to convert the "audio_unique_name" that is something like "ljspeech#wavs/LJ-0001" to a valid file name. I found two good ways to do that. The first uses regular expression and the second is with base64 which looks like the better solution. I kept the re version on the code just in case. Do you want me to remove this comment line?
There was a problem hiding this comment.
yeah I was about the comment line
There was a problem hiding this comment.
oh yeah, I removed it :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.