-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastspeech2 #2073
Fastspeech2 #2073
Conversation
Thanks for the ✨PR✨. This is awesome. We need some tests for EnergyDataset and the model here Also wondering, have you had a chance to train the model for real? |
Any plans on con'ting this PR? |
@erogol should i add vits changes in same pr ? |
@manmay-nakhashi better if you can send a separate PR for it. |
@erogol i have resolved the conflict any thing else i need to do ? |
@manmay-nakhashi thanks for updating the PR I'll try training the model and see how it works before going deeper in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on to the comments above, we need testing under tests/tts_tests/
for the Fastspeech2 model. You can check the FastPitch model as an example.
There are still tests that do not pass :( |
if you run |
styles has been fixed , tests are failing now because of yourtts model in zoo |
happens sometimes due to network incosistency. I restarted the failed jobs |
@erogol Did you try training this model or is something left to integrate this model? |
I haven't had a chance to try the model. I don't know when I can do that but I'll do asap if someone else doesn't do it earlier. |
I'll just merge for now and create follow up issues about the training. |
added compute energy module