Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastspeech2 #2073

Merged
merged 41 commits into from
Jan 15, 2023
Merged

Fastspeech2 #2073

merged 41 commits into from
Jan 15, 2023

Conversation

manmay-nakhashi
Copy link
Collaborator

added compute energy module

@erogol
Copy link
Member

erogol commented Oct 25, 2022

Thanks for the ✨PR✨. This is awesome.

We need some tests for EnergyDataset and the model here

Also wondering, have you had a chance to train the model for real?

TTS/tts/datasets/dataset.py Show resolved Hide resolved
@erogol
Copy link
Member

erogol commented Dec 5, 2022

Any plans on con'ting this PR?

@manmay-nakhashi
Copy link
Collaborator Author

@erogol should i add vits changes in same pr ?

@erogol
Copy link
Member

erogol commented Dec 6, 2022

@manmay-nakhashi better if you can send a separate PR for it.

@manmay-nakhashi
Copy link
Collaborator Author

@erogol i have resolved the conflict any thing else i need to do ?

@erogol
Copy link
Member

erogol commented Dec 12, 2022

@manmay-nakhashi thanks for updating the PR I'll try training the model and see how it works before going deeper in the code.

Copy link
Member

@erogol erogol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on to the comments above, we need testing under tests/tts_tests/ for the Fastspeech2 model. You can check the FastPitch model as an example.

TTS/tts/datasets/dataset.py Outdated Show resolved Hide resolved
TTS/utils/audio/numpy_transforms.py Show resolved Hide resolved
TTS/tts/layers/losses.py Show resolved Hide resolved
@erogol
Copy link
Member

erogol commented Jan 2, 2023

There are still tests that do not pass :(

@erogol
Copy link
Member

erogol commented Jan 4, 2023

if you run make style you would fix the remaining style issue.

@manmay-nakhashi
Copy link
Collaborator Author

manmay-nakhashi commented Jan 4, 2023

styles has been fixed , tests are failing now because of yourtts model in zoo

@erogol
Copy link
Member

erogol commented Jan 4, 2023

happens sometimes due to network incosistency. I restarted the failed jobs

@shivammehta25
Copy link
Collaborator

shivammehta25 commented Jan 14, 2023

@erogol Did you try training this model or is something left to integrate this model?

@erogol
Copy link
Member

erogol commented Jan 15, 2023

I haven't had a chance to try the model. I don't know when I can do that but I'll do asap if someone else doesn't do it earlier.

@erogol
Copy link
Member

erogol commented Jan 15, 2023

I'll just merge for now and create follow up issues about the training.

@erogol erogol merged commit bc422f2 into coqui-ai:dev Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants