Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "formatter" key in the datasets json array #2114

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

humada05
Copy link
Contributor

Currently if one uses the config.json file provided by the tutorial, this error occurs:

$> CUDA_VISIBLE_DEVICES="0" python TTS/bin/train_tts.py --config_path config.json
Traceback (most recent call last):
  File "TTS/bin/train_tts.py", line 71, in <module>
    main()
  File "TTS/bin/train_tts.py", line 51, in main
    eval_split_size=config.eval_split_size,
  File "/Users/ahmed/dev/TTS/TTS/tts/datasets/__init__.py", line 118, in load_tts_samples
    formatter = _get_formatter_by_name(formatter_name)
  File "/Users/ahmed/dev/TTS/TTS/tts/datasets/__init__.py", line 165, in _get_formatter_by_name

The load_tts_samples() function is expecting that the formatter field is set, the key word 'name' is nowhere to be found.

Currently if one uses the config.json file provided by the tutorial, this error occurs:
```python
$ TTS % CUDA_VISIBLE_DEVICES="0" python TTS/bin/train_tts.py --config_path config.json
Traceback (most recent call last):
  File "TTS/bin/train_tts.py", line 71, in <module>
    main()
  File "TTS/bin/train_tts.py", line 51, in main
    eval_split_size=config.eval_split_size,
  File "/Users/ahmed/dev/TTS/TTS/tts/datasets/__init__.py", line 118, in load_tts_samples
    formatter = _get_formatter_by_name(formatter_name)
  File "/Users/ahmed/dev/TTS/TTS/tts/datasets/__init__.py", line 165, in _get_formatter_by_name
```

The `load_tts_samples()` function is expecting that the `"formatter"` field is set, the key word "name" is no where to be found.
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2022

CLA assistant check
All committers have signed the CLA.

@erogol erogol changed the base branch from main to dev November 1, 2022 11:50
@erogol
Copy link
Member

erogol commented Nov 1, 2022

thanks for the fix. I merge it to dev.

@erogol erogol merged commit 5ccef6e into coqui-ai:dev Nov 1, 2022
@humada05 humada05 deleted the patch-1 branch November 3, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants