Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neon models #2140

Merged
merged 21 commits into from
Nov 16, 2022
Merged

Add neon models #2140

merged 21 commits into from
Nov 16, 2022

Conversation

loganhart02
Copy link
Contributor

@erogol Let me know if there is anything wrong with he model.json addition. Ill ping you when all models are added so we can merge

@loganhart02 loganhart02 marked this pull request as ready for review November 10, 2022 17:50
@loganhart02 loganhart02 self-assigned this Nov 10, 2022
@king-dahmanus
Copy link

hey. What's the difference between this neon model and the previous vits one. Is it possible to keep both of them at the same time instead of replacing? I'm interested to know the differences

@loganhart02
Copy link
Contributor Author

loganhart02 commented Nov 10, 2022 via email

@erogol erogol changed the title Add neon ljspeech vits model Add neon models Nov 11, 2022
@king-dahmanus
Copy link

Alright, thanks for the info

Copy link

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in author name. Also, I see one model has a description; should that be duplicated to the other added models? I'm not sure where all its referenced, just noticed its inconsistent.

TTS/.models.json Outdated Show resolved Hide resolved
TTS/.models.json Outdated Show resolved Hide resolved
TTS/.models.json Outdated Show resolved Hide resolved
TTS/.models.json Outdated Show resolved Hide resolved
TTS/.models.json Outdated Show resolved Hide resolved
TTS/.models.json Outdated Show resolved Hide resolved
TTS/.models.json Outdated Show resolved Hide resolved
@erogol erogol merged commit ff9b63d into dev Nov 16, 2022
@erogol erogol deleted the Neon-Models-Release branch November 16, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants