Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Update wavenet.py #2463

Closed
wants to merge 2 commits into from
Closed

[minor] Update wavenet.py #2463

wants to merge 2 commits into from

Conversation

p0p4k
Copy link
Contributor

@p0p4k p0p4k commented Mar 28, 2023

  1. (based on https://github.com/jaywalnut310/vits)
  2. In the earlier PR Update wavenet.py #1796 , I made a mistake about understanding the WaveNet architecture.
  3. If we follow the current implementation, hidden_channels will always have to be equal to in_channels. For a general use of this model, I had changed the res_skip_layers to output 2 x in_channels at every except the last layer and in_channels at the last layer.
  4. This change will not break existing GlowTTS and VITS models as they use num_hidden_channels == num_in_channels for their respective implementations.
  5. (minor|experimental) Having said that, there could be a use of dropout after the fused tanh sigmoid activation layer, which I have added as a comment for experimentation with a warning that it will break BC if used.

@p0p4k p0p4k changed the title Update wavenet.py [minor] Update wavenet.py Mar 28, 2023
@p0p4k p0p4k closed this by deleting the head repository Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant