Fix zh bug #3238
Merged
Fix zh bug #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edresson
reviewed
Nov 16, 2023
| @@ -396,7 +396,7 @@ def inference_with_config(self, text, config, ref_audio_path, language, **kwargs | |||
| inference with config | |||
| """ | |||
| assert ( | |||
| language in self.config.languages | |||
| "zh-cn" if language == "zh" else language in self.config.languages | |||
There was a problem hiding this comment.
It will return "zh-cn" when language == "zh" and it will check if not. It is ok but for both conditional returns the same data type it should be True if language == "zh" else language in self.config.languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
zhcode is more fitting but we currently usezh-cnin the config and tokenzier, changing those file would trigger a re-download for everyone using v2. This fix should allow support for both codes.