Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Chinese lang from 'zh' to 'zh-cn' in xtts tokenizer #3242

Closed
wants to merge 1 commit into from

Conversation

bojieli
Copy link

@bojieli bojieli commented Nov 16, 2023

The language name of Chinese should be "zh-cn" rather than "zh". However, in some places of xtts tokenizer, e.g., _abbreviations and _symbols_multilingual, the keys are "zh", leading to exception when the language is set to "zh-cn". This patch updates the language name from "zh" to "zh-cn".

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@WeberJulian
Copy link
Contributor

Could you please try the latest dev? I already fixed this issue in a PR.

@bojieli
Copy link
Author

bojieli commented Nov 17, 2023

Could you please try the latest dev? I already fixed this issue in a PR.

Sure, thanks for fixing that.

@bojieli bojieli closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants