Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev pr3 : small changes for chinese implementation #6

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

kirianguiller
Copy link
Contributor

@kirianguiller kirianguiller commented Feb 26, 2021

Hi guys,

Here the third split of the PR I did earlier this week ! (finally the last one :) )

In this PR,

  • I've changed the name of the phoneme language variable ( 'chinese-mandarin' -> 'zh-CN') for more conciseness.
  • I've changed the .models.json google drive identifiers for a new model that trained 130k epochs.

Thanks for your reviews !

@kirianguiller kirianguiller changed the title Dev pr3 Dev pr3 : small changes for chinese implementation Feb 26, 2021
@erogol
Copy link
Member

erogol commented Mar 1, 2021

This PR still includes abstraction classes and other changes than only the Chinese model.

Is it international or you forgot to remove the other changes?

@kirianguiller
Copy link
Contributor Author

I was thinking that if you merged the pr1 first, then I can rebase pr2 and pr3 (so the commits in the pr1 are added to the dev and then they are not being compared anymore for pr2 and pr3).

Then, if doing the same after merging pr2, i can rebase pr3 with the new dev, and the only differents commits between this new dev and the pr3 will be the commits regarding chinese implementation.

I was not sure of doing these PRs, and I found some people online recommending this way. You want to do it another war ?

@kirianguiller
Copy link
Contributor Author

Hey, I've just changed the branch for only including the changes relative to the new chinese model

@erogol erogol merged commit d706d4c into coqui-ai:dev Mar 2, 2021
@erogol
Copy link
Member

erogol commented Mar 2, 2021

THIS IS AWESOME !! THX !!

@erogol
Copy link
Member

erogol commented Mar 8, 2021

@kirianguiller btw what vocoder does this model use ?

@kirianguiller
Copy link
Contributor Author

kirianguiller commented Mar 8, 2021

The following melgan-multiband :

"ljspeech":{
                "multiband-melgan":{
                    "model_file": "1Ty5DZdOc0F7OTGj9oJThYbL5iVu_2G0K",
                    "config_file": "1Rd0R_nRCrbjEdpOwq6XwZAktvugiBvmu",
                    "stats_file": "11oY3Tv0kQtxK_JPgxrfesa99maVXHNxU",
                    "commit": "ea976b0",
                    "author": "Eren Gölge @erogol",
                    "license": "MPL",
                    "contact":"erengolge@gmail.com"
                }
            }

It's working really well :)

eginhard referenced this pull request in idiap/coqui-ai-TTS Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants