Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-static method called statically in Configuration.php #326

Closed
t4k opened this issue Nov 2, 2017 · 1 comment
Closed

Non-static method called statically in Configuration.php #326

t4k opened this issue Nov 2, 2017 · 1 comment
Assignees
@t4k

Comments

@t4k
Copy link
Contributor

t4k commented Nov 2, 2017 •
edited
Loading

Reported on the coral-user mailing list: http://lists.coral-erm.org/pipermail/coral-user/2017-November/000208.html

Deprecated: Non-static method Utility::objectFromArray() should not be called statically in …/auth/admin/classes/common/Configuration.php on line 35

Line 35 should probably read:

$this->$section = (new Utility())->objectFromArray($entries);

Untested at this point. This will have to be fixed in every module’s Configuration class.
@t4k t4k self-assigned this Nov 2, 2017
@t4k
Copy link
Contributor Author

t4k commented Nov 2, 2017

This does seem to be the solution. I will add a PR.

t4k added a commit to caltechlibrary/coral that referenced this issue Nov 2, 2017
@t4k
Issue coral-erm#326: Fix statically called non-static method.
7df41d6
@t4k t4k mentioned this issue Nov 2, 2017
Merged
veggiematts added a commit that referenced this issue Jan 29, 2018
@veggiematts
Merge pull request #327 from caltechlibrary/326-deprecated-static-method
aad5c9a 
Issue #326: Fix statically called non-static method.
@t4k t4k closed this as completed Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t4k t4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t4k