Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links should not be capitalized #369

Closed
veggiematts opened this issue Mar 12, 2018 · 6 comments
Closed

Links should not be capitalized #369

veggiematts opened this issue Mar 12, 2018 · 6 comments
Labels
bug This is a bug (not an enhancement)

Comments

@veggiematts
Copy link
Contributor

Many links in Coral are capitalized, like this one:

Add New Resource Type

This is done through the following CSS rule:

text-transform: capitalize;

Capitalizing is not a correct grammar rule in many languages.
We should not enable it by default for every language.

@PaulPoulain PaulPoulain added the bug This is a bug (not an enhancement) label Mar 12, 2018
@PaulPoulain
Copy link
Contributor

linked to #380

@jeffnm
Copy link
Contributor

jeffnm commented Mar 22, 2018

I'm not sure this is a bug.

Isn't capitalization of links a style choice, not a grammar issue? It is sometimes referred to as Title Case, since most titles are capitalized in that manner. But I don't think it's a grammar issue in English, at any rate, any more than using ALL CAPS, which would be frowned upon for style reasons, but which is not a grammatical issue.

I'm fine with us deciding that we want to change that style choice, if that's what we actually want to do. #371 looks like it does that well.

I'd be more convinced that this is a bug if non-latin scripts have problems with text-transform: capitalize;. I'll of course defer to the localization experts on this if it's an issue, I'd just like to understand why a little better.

@PaulPoulain
Copy link
Contributor

I strongly disagree: in French, this is a bug (and same thing in German, dunno for other languages, but I suspect Italians & Spanish ppl would say the same thing) : it's not good French to see "Ajouter Une Nouvelle Organisation".

So, if the English version must have a capitalized 1st letter for every word, then the strings must be capitalized in English, that must not be done through CSS, but in the code. Thus, localized version can be as they have to be.

BTW, closing this issue, as it's a duplicate of #371

@PaulPoulain
Copy link
Contributor

sorry, I was confused between issue & PR...

@PaulPoulain PaulPoulain reopened this Mar 23, 2018
@jeffnm
Copy link
Contributor

jeffnm commented Mar 23, 2018

This isn't an issue I want to argue about, it just sounded like a style issue rather than a grammar one, which made me question the bug label.

I found this article to help explain that French uses fewer capitalizations in general, even in titles: https://www.thoughtco.com/use-of-french-capitalization-4085543

So it's not just that Paul doesn't like capitalizations ;-)

One final question, just for my own education, in the following screenshot, are all the arrows pointing to equally bad capitalizations?

screen shot 2018-03-23 at 8 55 01 am

I'm guessing yes, except for the "Funds" example, because I just checked the existing French version and all those left and top menu items are only capitalized on the first word, it's only the interface links that are all caps still.

That definitely lends credence to the it's a bug argument as it's now inconsistent between sections of the French translation!

@PaulPoulain
Copy link
Contributor

PaulPoulain commented Mar 23, 2018 via email

@jeffnm jeffnm closed this as completed Apr 5, 2018
@jeffnm jeffnm added this to the Version 3.0.0 Beta milestone Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug (not an enhancement)
Projects
None yet
Development

No branches or pull requests

3 participants