-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr63 #101
Conversation
- Add new fields to the enhanced acquisitions mode: - Price Tax Excluded - Tax Rate - Price Tax Included Price Tax Included and Payment Amount will be automatically prefilled accoring to the Price Tax Excluded and Tax Rate values.
Conflicts: ajax_forms/getCostForm.php ajax_htmldata/getAcquisitionsDetails.php
Conflicts: resources/ajax_forms/getCostForm.php resources/ajax_htmldata/getAcquisitionsDetails.php resources/ajax_processing/submitCost.php resources/js/forms/costForm.js
`TypeError: pAmount is undefined `
I stopped testing when I hit the javascript errors. |
Due to a major commit made to the master branch back in June, a key step in the algorithm in While Loop in function validateTable(objRows) in costForm.js is found not correctly established. Instead of directly editing costForm.js in this PR, for your reference, I paste as below the lines in bold to be added/modified/removed. Also, the said changes have been made in #43 . |
@jsavell , though you see the errors with this pull request, but those errors are not introduced by this pull request. Those errors will be fixed by PR #43 and I have tested locally to support this statement. My test also shows the tax fields function as expected. So I think you can merge this PR now. PR #43 will be merged by us next . |
This is a fresh PR replacing #3
Add new fields to the enhanced acquisitions mode:
Price Tax Excluded
Tax Rate
Price Tax Included
Price Tax Included and Payment Amount will be automatically prefilled accoring
to the Price Tax Excluded and Tax Rate values.