-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow enhancements: restart, archive and edit workflow #117
Workflow enhancements: restart, archive and edit workflow #117
Conversation
- Remove obsolete condition - Fix completed workflow restart
- Fix workflow display order
- Followup: fix completed workflow restart
- Add automation: when a workflow is restarted, it is archived if it is complete and deleted otherwise.
- Fix UI - Reindenting - Update steps in parent window after submit
- Fix steps adding and deletion
- Place js functions outside $(document).ready
- Fix function call typo
- Disable group edition for completed steps.
- Fix UI bugs
- Add the ability to reorder steps (WIP)
- Add the ability to reorder steps (Follow-up)
- Fix delete step
- Set start date for newly-added resource steps
…Add_a_step_in_a_resource_workflow_with_archiving_a_workflow Conflicts: resources/ajax_htmldata/getRoutingDetails.php
- Do not display archived workflows steps - Add resource steps to the step table - Fix resource steps order in edition
- Display current and archived workflow in a more distinctive way.
- Add icons for showing/hiding archived resources
- Add icons for showing/hiding archived resources
- Fix RF45854: When testing edit current workflow if you try to enable the workflow mail reminder and save it automatically makes all steps in the workflow active. In the routing tab, for the workflow step with a parent, “mark complete” should not appear until the parent step is completed.
- RF46396: set new resourceType, resourceFormat and acquisitionType for the resource, according to the selected workflow
- RF46396: Add 'Any' to ResourceType, ResourceFormat and AcquisitionType, and set those values to the Resource if needed when restarting a workflow.
…g_a_workflow' into RF41380_Add_a_step_in_a_resource_workflow_with_archiving_a_workflow_rebased
Can you only archive a completed workflow or can you archive one still in progress? If the latter, what happens when you archive an in progress workflow? does it mark it as complete? |
Ben, yes, you can only archive a completed workflow. More specifically once a workflow is completed, it'll be archived automatically. Let me know if you have more question about this. Thanks! |
@xsong9 if i have only one workflow and it is completed does it display on the routing tab without having to click another 'display archived workflows'? I do not think that a completed workflow should be hidden automatically. I'd rather keep the complete workflow and archive workflow feature separate. Automatically archiving (and hiding behind an extra link) a completed workflow would not be optimal for folks that don't intend to use the archive workflow feature which is mostly only relevant when there are multiple workflows on the same record. |
I'm not suggesting any changes to that functionality with my comment, only looking for clarification. I'd be fine with this being merged and submitting an issue for any modifications that we'd want to make. |
@benheet A completed workflow will be archived automatically but it will not disappear from the routing tab until a new workflow is restarted. Hope this cleared your confusion. |
There are no conflicts noted for this pull request. If NCSU agrees to update the relevant documentation for the v2.0 launch then I suggest that this be merged now and we'll deal with problems later. This makes significant changes and I'd rather see it included in v2.0 launch then be a new change soon after. To be clear I'm proposing we forgo our 2nd party testing workflow and just merge this one. |
I'm ok with that as long as the 2.0 Beta gets some more thorough testing. |
We will update the documentation for the v2.0 launch. |
@veggiematts can you resolve the conflicts on this pull request? |
@xsong9 thank you for your willingness to contribute the documentation. please consult with @scottvieira on adding your documentation contributions to the v2.0 documentation. |
…in_a_resource_workflow_with_archiving_a_workflow
New features:
selecting a workflow from a pre-defined workflow list or restart the current completed workflow.
information, such as date when tasks are completed, and such information shall be kept.
offers users greater flexibility to determine a customized workflow for a specific resource. CORAL
provides a globalized add a step function in the Admin section, which applies to all resources
associated with this workflow, not on individual resource level.