Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow enhancements: restart, archive and edit workflow #117

Conversation

veggiematts
Copy link
Contributor

New features:

  • Restart a completed workflow: Users shall be provided the ability to restart a new workflow by
    selecting a workflow from a pre-defined workflow list or restart the current completed workflow.

workflow_1
workflow_2

  • Provide ability to archive previous workflows: Previously completed workflows contain valuable
    information, such as date when tasks are completed, and such information shall be kept.

workflow_3

  • Provide the ability to add a step in the workflow for a particular resource: The ability to add a step
    offers users greater flexibility to determine a customized workflow for a specific resource. CORAL
    provides a globalized add a step function in the Admin section, which applies to all resources
    associated with this workflow, not on individual resource level.

workflow_4
workflow_5
workflow_6

 - Remove obsolete condition
 - Fix completed workflow restart
 - Fix workflow display order
 - Followup: fix completed workflow restart
 - Add automation: when a workflow is restarted, it is archived if it is
   complete and deleted otherwise.
 - Fix UI
 - Reindenting
 - Update steps in parent window after submit
 - Fix steps adding and deletion
 - Place js functions outside $(document).ready
 - Disable group edition for completed steps.
  - Add the ability to reorder steps (WIP)
 - Add the ability to reorder steps (Follow-up)
 - Set start date for newly-added resource steps
…Add_a_step_in_a_resource_workflow_with_archiving_a_workflow

Conflicts:
	resources/ajax_htmldata/getRoutingDetails.php
 - Do not display archived workflows steps
 - Add resource steps to the step table
 - Fix resource steps order in edition
 - Display current and archived workflow in a more distinctive way.
 - Add icons for showing/hiding archived resources
 - Add icons for showing/hiding archived resources
 - Fix RF45854:
   When testing edit current workflow if you try to enable the workflow mail reminder and save it automatically makes all steps in the workflow active.
   In the routing tab, for the workflow step with a parent, “mark complete” should not appear until the parent step is completed.
 - RF46396: set new resourceType, resourceFormat and acquisitionType for the resource, according to the selected workflow
 - RF46396: Add 'Any' to ResourceType, ResourceFormat and AcquisitionType,
 and set those values to the Resource if needed when restarting a workflow.
…g_a_workflow' into RF41380_Add_a_step_in_a_resource_workflow_with_archiving_a_workflow_rebased
@benheet
Copy link
Contributor

benheet commented Oct 18, 2016

Can you only archive a completed workflow or can you archive one still in progress? If the latter, what happens when you archive an in progress workflow? does it mark it as complete?

@xsong9
Copy link
Contributor

xsong9 commented Oct 19, 2016

Ben, yes, you can only archive a completed workflow. More specifically once a workflow is completed, it'll be archived automatically. Let me know if you have more question about this. Thanks!

@benheet
Copy link
Contributor

benheet commented Oct 19, 2016

@xsong9 if i have only one workflow and it is completed does it display on the routing tab without having to click another 'display archived workflows'? I do not think that a completed workflow should be hidden automatically. I'd rather keep the complete workflow and archive workflow feature separate. Automatically archiving (and hiding behind an extra link) a completed workflow would not be optimal for folks that don't intend to use the archive workflow feature which is mostly only relevant when there are multiple workflows on the same record.

@benheet
Copy link
Contributor

benheet commented Oct 19, 2016

I'm not suggesting any changes to that functionality with my comment, only looking for clarification. I'd be fine with this being merged and submitting an issue for any modifications that we'd want to make.

@xsong9
Copy link
Contributor

xsong9 commented Oct 22, 2016

@benheet A completed workflow will be archived automatically but it will not disappear from the routing tab until a new workflow is restarted. Hope this cleared your confusion.

@xsong9
Copy link
Contributor

xsong9 commented Nov 9, 2016

#9

@benheet
Copy link
Contributor

benheet commented Nov 16, 2016

There are no conflicts noted for this pull request. If NCSU agrees to update the relevant documentation for the v2.0 launch then I suggest that this be merged now and we'll deal with problems later. This makes significant changes and I'd rather see it included in v2.0 launch then be a new change soon after. To be clear I'm proposing we forgo our 2nd party testing workflow and just merge this one.

@jeffnm
Copy link
Member

jeffnm commented Nov 16, 2016

I'm ok with that as long as the 2.0 Beta gets some more thorough testing.

@xsong9
Copy link
Contributor

xsong9 commented Nov 17, 2016

We will update the documentation for the v2.0 launch.

@benheet
Copy link
Contributor

benheet commented Nov 17, 2016

@veggiematts can you resolve the conflicts on this pull request?

@benheet
Copy link
Contributor

benheet commented Nov 17, 2016

@xsong9 thank you for your willingness to contribute the documentation. please consult with @scottvieira on adding your documentation contributions to the v2.0 documentation.

…in_a_resource_workflow_with_archiving_a_workflow
@benheet benheet merged commit 579e640 into coral-erm:master Nov 28, 2016
@PaulPoulain PaulPoulain added this to the Version 2.0.0 milestone Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants