Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate costs in export #316

Merged

Conversation

veggiematts
Copy link
Contributor

Separate acquisition information in export in a way they can be used:

  • Split fund name, fund code, payment amount, currency code and order type in multiple rows
  • Add missing fields: price tax excluded, tax rate, price tax included, order details, year, cost note and invoice display
  • Export as many lines as there are acquisition information
  • Fix broken isbn or issn export
  • Make CSV export columns translatable

  - Split fund name, fund code, payment amount, currency code and order type in multiple rows
  - Add missing fields: price tax excluded, tax rate, price tax included and order details
  - Export as many lines as there are acquisition information
  - Fix broken isbn or issn export
Add year, cost note and invoice display
@veggiematts
Copy link
Contributor Author

About the translation, should I commit the updated po in this Pull Request, or wait for the string freeze before the new release ?

@PaulPoulain PaulPoulain added the enhancement This is an enhancement (not a bug) label Dec 12, 2017
@jeffnm jeffnm added this to the Version 2.1.0 Beta milestone Dec 14, 2017
@fondrenlibrary fondrenlibrary self-requested a review December 14, 2017 16:39
@fondrenlibrary
Copy link
Contributor

It works as expected.

@veggiematts veggiematts merged commit 5d00c77 into coral-erm:development Jan 3, 2018
@scottvieira
Copy link
Contributor

I'm closing this issue without any additional documentation. It seems like this is just allowing the export of enhanced cost data which would be a subset of the general resources export functionality now included under the appendix in the documentation for Exporting in CORAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement (not a bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants