Issue 433: Fix some resource searches #434
Conversation
This patch fixes the following resource searches: Funds Note type Note content Purchase site Authorized site Administering site Authentication type Cataloging status Workflow step
|
@cjc66 Asked me to test this. Before it seems the searches were returning 500 errors. While they no longer return 500 errors, some of the searches do not appear to work as intended. Authorized Site, Administering Site Note Type & Content: Notes on the product tab are not search However, if I filter by Note Type "Access Details", I get results because this second note exists in the acquisitions tab. The same is true for access & cataloging tabs. |
| LEFT JOIN ResourceAuthorizedSiteLink RAUSL ON R.resourceID = RAUSL.resourceAcquisitionID | ||
| LEFT JOIN ResourceAdministeringSiteLink RADSL ON R.resourceID = RADSL.resourceAcquisitionID | ||
| LEFT JOIN ResourcePayment RPAY ON RA.resourceAcquisitionID = RPAY.resourceAcquisitionID | ||
| LEFT JOIN ResourceNote RN ON RA.resourceAcquisitionID = RN.entityID |
There was a problem hiding this comment.
One problem is that the ResourceNote table "entityID" field only exists in the 3.0.0/002-350.sql upgrade script, so it (and maybe more) needs to be added to the main install.sql (right? is that still our approach to fresh installations?).
There was a problem hiding this comment.
I'm not sure. I thought we decided that fresh installs would process install.sql and the upgrade scripts. Can someone confirm this?
There was a problem hiding this comment.
@veggiematts, correct. When installing the scripts process install.sql and all upgrade sql files as long as the upgrade files are contained within a version directory, e.g. /$MODULE/install/protected/$VERSION
Here is the PR
There was a problem hiding this comment.
@queryluke @veggiematts Got it. Thanks for the clarification.
|
This follow-up should fix the problems @queryluke mentioned. |
|
Yes, I have confirmed this is working. |
Fix for issue #433
This patch fixes the following resource searches:
Funds
Note type
Note content
Purchase site
Authorized site
Administering site
Authentication type
Cataloging status
Workflow step