Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resources menu display for turkish translation #499

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Fix resources menu display for turkish translation #499

merged 2 commits into from
Oct 23, 2018

Conversation

veggiematts
Copy link
Contributor

  • Use unicode string comparison for privileges check

@veggiematts
Fix resources menu display for turkish translation
db2f2dd 
 - Use unicode string comparison for privileges check
@veggiematts veggiematts added the bug This is a bug (not an enhancement) label Oct 11, 2018
@veggiematts
Copy link
Contributor Author

Fix for #500

@ozhansaglik
Copy link

Hi,

We did the changes but the problem is still valid.

@ozhansaglik
Copy link

@veggiematts Did you have a chance to examine problem?

@veggiematts
Copy link
Contributor Author

The provided fix solved the problem on my instance (PHP 7.0.32)
Did anyone else had a chance to test this?

@jeffnm jeffnm self-requested a review October 23, 2018 13:34
jeffnm
jeffnm suggested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@jeffnm jeffnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with the one change I suggested on line 72. If changed, I'll merge.

resources/admin/classes/domain/User.php Outdated Show resolved Hide resolved
@jeffnm @veggiematts
Update resources/admin/classes/domain/User.php
fe5dad1 
Co-Authored-By: veggiematts <matthias.meusburger@gmail.com>
@veggiematts
Copy link
Contributor Author

You're right @jeffnm . I applied your change, feel free to merge.

@jeffnm jeffnm merged commit 5b143ae into coral-erm:development Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffnm jeffnm jeffnm approved these changes

Assignees
No one assigned
Labels
bug This is a bug (not an enhancement)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veggiematts @ozhansaglik @jeffnm