Allow to specify date format in common/configuration.ini #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Coral's date format is hardcoded in common/common_directory.php This patch allows to specify the date format in common/configuration.ini, with a fallback to the default date format if nothing is specified.
This was referenced Dec 18, 2018
|
Tested, and this PR works the same as changing the code in common/common_directory.php. It mostly works as intended on most pages where dates are displayed, but I have opened two separate issues: Issue 520 and Issue 521. Since the behavior is the same in changing the code directly (locally) or applying this PR, I would argue that this works as intended and that new PR:s should be created for the new issues. |
Use strftime instead of strtotime to have common date format between php and mysql.
|
In order to fix Issue #521, the date format is now like: "%m/%d/%Y" |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Coral's date format is hardcoded in common/common_directory.php
This patch allows to specify the date format in common/configuration.ini, with a fallback to the default date format if nothing is specified.