Issue 360: PHP 7.2 compatibility #541
Conversation
- Rename Object class in source code
- Rename files
|
Not tested yet, and I think statements like this : |
- Follow-up
|
Tested quickly with the follow-up, seems ok. Help wanted for some more tests. |
This reverts commit 3229d41.
|
@veggiematts I messed up somehow. I was pulling your I didn't think I had permissions to commit or merge to the Biblibre repository, but that seems to be what has happened, and I don't see anyway to reset it back to the previous state. The only explanation I can think of is that there was a merge conflict (I had renamed my Auth module's Object class already on that branch), and somehow in the process of resolving that it must have pushed my changes back to your repo. I wonder if it's because this PR was opened to CORAL-ERM's repo and I have permission through the CORAL-ERM organization to push changes back to the source branch of open pull requests? On the plus side, the travis-ci integration is working well enough that it ran a passing build check on this pull request now that my changes for that are included? Sorry! Let me know if I can help clean things up somehow. |
veggiematts
force-pushed
the
Issue_360_php_compat
branch
from
5594fb5 to
942be82
Compare
|
That's... strange. Anyway, I just pushed-force on the branch to revert it back to its previous state. |
|
Thanks! |
|
Hey Veggiematts, I made the same changes on our internal environement independently (before finding this issue) and it seems to be working ok. I'll let you know if I run into any issues. |
|
It looks like a relatively simple change, and @jeffnm says it passed some rudimentary tests, so I would say go for it. It'll be easier to debug if need be when I am more actively working with the development branch locally. |
PR for Issue #360, using provided shell script.