Issue #543: set $expression->lastUpdateDate

[t4k]

The real changes besides white space include:

• set $expression->productionUseInd to a string in the else clause
• avoid rewriting $expression->productionUseInd immediately after the else clause (if it is an update and the value is already set, it would have been always overwritten)
• set $expression->lastUpdateDate = date('Y-m-d H:i:s'); so that we don't get the cannot be null error

Issue #543

TEST PLAN

Environment (I believe the problem lies in the MySQL configuration):

• PHP Version 7.0.33-0ubuntu0.16.04.1
• MySQL Server version: 5.6.40-log Source distribution (AWS RDS)
  • explicit_defaults_for_timestamp set to TRUE
• Apache/2.4.18 (Ubuntu)

Confirmation of Problem

Without the patch, when trying to add an Expression to a License in the Licensing module, the error There was a problem with the database: Column 'lastUpdateDate' cannot be null is shown and the Expression cannot be saved.

Resolution

With the patch, the lastUpdateDate value is explicitly set so that the DatabaseObject code is not finding no value and trying to set the field to NULL. The Expression should save without any problems.

[jeffnm]

Hey @t4k, could you suggest a testing plan for this PR?

[t4k]

I found out why this is so difficult to reproduce. It has to do with the explicit_defaults_for_timestamp that is set to TRUE by default on AWS RDS MySQL 5.6.

When this value is set we run into a problem because the code

coral/licensing/admin/classes/common/DatabaseObject.php

Lines 223 to 224 in 9752600

	if ($value == '' || !isset($value)) {
	$value = "NULL";

is trying to save a NULL value for the field. Now this would be normally overcome by the schema setting of

coral/licensing/install/protected/install.sql

Line 51 in 9752600

`lastUpdateDate` timestamp NOT NULL default CURRENT_TIMESTAMP,

but it seems that the MySQL configuration overrides that schema setting.

I've updated the issue with a test plan.