Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 581: Specify datepickers date format in common/configuration.ini #582

Merged

Conversation

veggiematts
Copy link
Contributor

Background: Issue #581 : We shouldn't have to patch Coral to specify a date format for the datepickers (see PR #523) but rather be able to specify it in the main configuration file.

Datepickers date format can be specified in common/configuration.ini, as such:

[settings]
datepicker_date_format = "dd/mm/yyyy";

If datepicker_date_format is omitted, it will be defaulted to 'mm/dd/yyyy'

Datepickers date format can be specified in common/configuration.ini, as such:

[settings]
datepicker_date_format = "dd/mm/yyyy";

If datepicker_date_format is omitted, it will be defaulted to 'mm/dd/yyyy'
@jeffnm
Copy link
Member

jeffnm commented Apr 29, 2019

This looks good to me.

At some point we should add access for changing this setting in the Admin interface and/or in the Installer.

@jeffnm jeffnm added the enhancement This is an enhancement (not a bug) label Apr 29, 2019
@jeffnm jeffnm merged commit 26e8fce into coral-erm:development Apr 29, 2019
queryluke added a commit to queryluke/coral that referenced this pull request Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement (not a bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants